Repository navigation
Keep effective model and effort history in conversations - #1948
Open
currentbits wants to merge 10 commits into
Open
currentbits wants to merge 10 commits into
currentbits wants to merge 10 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03fc2f8240
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Nov 8, 2026
added 4 commits
November 8, 2026 13:37
4 tasks
added 4 commits
November 8, 2026 15:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing model or reasoning effort left no reliable record in a conversation, and historical footers could follow the current picker instead of the run that produced the message.
Persist the effective provider/model/effort when a run is dispatched or a live model switch takes effect. Render deduplicated boundaries and retain assistant attribution across reload and paged history. Queued prompts are stamped at dispatch, live steering retains its current run, and failed launches remove provisional markers. Claude effort comes from resolved launch arguments, including Ultracode's xhigh override. Unknown provider defaults and internal Ask/workflow selections remain explicitly unknown/default rather than being guessed.
Validation: 96 and 44 focused Electron tests, 221 history/plan/renderer tests, typecheck and preload synchronization passed. The follow-up Ultracode regression run passed 27 tests with one existing Windows-only skip. Independent review confirmed the Ultracode fix and reran 23 focused tests with no material findings. No real-provider smoke test was performed.
Closes #1927. Part of #1926.
Created with GPT-6.1 Sol in Codex, including GPT-6.1 Sol implementation and review workers.